Skip to content

re-add elpi 1.18.2 #28219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2025
Merged

re-add elpi 1.18.2 #28219

merged 2 commits into from
Jul 24, 2025

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Jul 22, 2025

This was referenced Jul 22, 2025
Merged
Open
@Zeta611
Copy link
Member

Zeta611 commented Jul 24, 2025

All tests are currently failing with

# File "trace/ppx/trace_ppx.ml", line 176, characters 6-14:
# 176 |     | Pexp_fun(_,_,pat,rest) when not !enabled ->
#             ^^^^^^^^
# Error: This variant pattern is expected to have type "Ppxlib.expression_desc"
#        There is no constructor "Pexp_fun" within type "Ppxlib.expression_desc"
# Hint: Did you mean "Pexp_for"?

@hannesm
Copy link
Member Author

hannesm commented Jul 24, 2025

Thanks for noticing, I added an upper bound for ppxlib, and now CI looks happy -- apart from some "resource unavailable for Thread.create" -- which I'm happy to ignore.

So, good to merge from my point of view.

@mseri
Copy link
Member

mseri commented Jul 24, 2025

Thanks!

@mseri mseri merged commit 8059aee into ocaml:master Jul 24, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannesm @Zeta611 @mseri @shonfeder